jacklandrin/OnlySwitch

Settings dialogue behind main window / radio icon always shown

despecial opened this issue · 16 comments

It's probably not a real bug - just not ideal
Using 2.3.4 on MacOS Monterey 12.2

1.) Activating the settings will open the window behind the main window. This should be vice versa
2.) I do not use the radio but the player symbol is always shown in my menu bar - how to disable this?

Thanks!

Thank you for the report.

  1. Main window means the popover window, right? Perhaps since I use a big screen, I didn't consider the popover covers settings window. How do you think the popover hides when settings window shows?
  2. Go to System Preferences-> Dock & Menu bar -> Now Playing, you can toggle the symbol if shows in menu bar here.

Thanks for the response

1.) I would simply suggest that the settings window should always be above the main window (if thats open, or close it)
2.) I do not see that option and why isnt it a toggle in the app? :D
Bildschirmfoto 2022-07-13 um 19 44 09

@despecial

  1. Ok. Ich kann Einstellungenfenster über Hauptfenster macht.
    2 .Der Pfad auf Deutsch ist Systemeinstellungen -> Dock & Menüleiste -> Jetzt läuft -> In Menüleiste anzeigen.
    Jetzt läuft ist eine Systemfunktion von Mac, also die kann nur in den Systemeinstellungen umschalten werden.

@jacklandrin thanks for the headsup. I think something is wrong with the last update.
The option is set to show the icon when active. But nothing is playing and the radio is disabled in OpenSwitch.
So it shouldnt be shown.

Since its a system wide setting I want to keep it, because it is also active when using youtube, etc.
It's definately a setting/option which shows the radio play controls.

@despecial This feature is actually for media keys control. Once users just run OnlySwitch, can straightly play radio by keyboard. So the player is registered in Now Playing after launching, then the icon will display on menu bar.
I understand your demand, and consider adding a toggle for your case in next version. It can manipulate the timing of registering, after launching or after first playing. How do you think the plan?

You should only register it WHEN radio is enabled in OnlySwitch.
If its not activated (radio), then the controls should also not be active/visible.

In the Individuell Einrichten switches just toggle visible/invisible in popover's list instead of enable/disable. Though a switch is off on this setting, you still can control it via hotkeys. This is why the switch Menüleistensymbol ausblenden has an independent enable toggle. I can understand your suggestion, but that violates this common design principle.

I believe you mix something up.

As you can see in my screenshot, the radio player is not active but still the play icon is visible in the menu bar
If I go to individual settings and deactivate the radio player completely - the icon still shows up in the menu bar.

Logically, the icon should never be visible if the radio player is not activated.
Not sure what you mean by design principle. THIS is the principle > if nothing is activated, it has no reason to be visible
Bildschirmfoto 2022-07-14 um 00 01 49
.

When the radio player switch is off, it just means pause status. That is like you open Apple Music, and play a song, then pause it. You still can use media key or button on GUI to continue playing. Meanwhile, the now playing show on the menu bar until closing it.
However, if the radio is deactivated and unregister in Now playing at same time, the media keys won't work. Media keys controlling is the new feature in version 2.3.3(#36).
Unfortunately, Apple doesn't offer a stop status for the control center and now playing, so the symbol is always visible unless you close all players.
This is why I give you above suggestion. If you never use radio, you can never see OnlySwitch invoke the symbol.

Thanks for trying to explain.

As i said before: it still shows up, even if i completely disable the radio option in "Individuell Einrichten". Closed OnlySwitch > the play icon stays in the menu bar and radio is gone but apple music shows up (which is not used by me at all). There is no player to close.

And what should happen when activating "Spotify" on the individual pages? Because nothing happens when toggling it.

Bildschirmfoto 2022-07-14 um 00 33 23

Bildschirmfoto 2022-07-14 um 00 34 12

Thank you for the question.
The radio player in OnlySwitch is always alive when the app process is running. As I said "Individuell Einrichten" just means switches visible or invisible.
I can explain the princeple of Now Playing. The last player you play will be prior player in Now Playing, and it will also show on control center. Media Keys on keyboard only can control the prior player. So the Spotify will register in Now Playing when it's active. But if the Spotify process doesn't run, you can't see it on the list. Same situation for Apple Music switch. OnlySwitch watches their process.
If you have multiple players register in Now Playing, you will see a list of them when tap the symbol. If you kill the prior player's process, the second one will become prior, like a stack.
In this case, if you wanna unregister radio player but keep OnlySwitch is running. I can provide a toggle to control enable/disable radio function on settings.

Yes, that would be good to have a toggle that actually does what it says ;)

Because right now the use of a toggle for the radio player doesn't really make sense ("When the radio player switch is off, it just means pause status."). A play/pause button would be more accurate and better UX.

If you have multiple players register in Now Playing, you will see a list of them when tap the symbol. If you kill the prior player's process, the second one will become prior, like a stack.

I understand what you say and OnlySwitch should let the user be in control of what is activated and what not. So a switch to toggle the Radio functionality would be very appreciated.

PS: Spotify is not located under "audio" if its shown in OnlySwitch.

I feel Apple intent to avoid the stop status on its ecosystem. Whatever Apple Music or Spotify, only has play and pause two status. Of couse as you said, the play/pause button will be more accurate. I can improve it. I just follow the Switch princeple before, actually the clean button and run button haven't been Switch since eariler version. Indeed it perhaps brings some confuse to users.
The wrong category of Spotify and Apple Music is a bug, I'll fix it in next version.

BTW, for the question of settings window level. If let settings window above the popover window, settings window will above other apps' windows as well. Could you accept it?

If you would like, join the telegram group. https://t.me/OnlySwitchforMac
I'll release beta version on it, you can experience it to decide to what you want.

BTW, for the question of settings window level. If let settings window above the popover window, settings window will above other apps' windows as well. Could you accept it?

I am not aware how its done on MacOS but as a web developer you work with z-indexes. So if you open the settings, you just could lower the level of the main window: https://jameshfisher.com/2020/08/03/what-is-the-order-of-nswindow-levels/

Or use "floating": https://stackoverflow.com/a/48837042/6709432