on html email notification {title} is coming through blank
mmelon opened this issue · 4 comments
this is using the default theme. Also {domain} is coming through as all, but i can hardcode the domain
edit
except the subject of the email has the domain as all as well. What could be going wrong with my domain detection? I have tried adding "domain" : "mydomain.com" to the settings json. If I put another domain in there, front end comments fail with external not allowed or similar, so it's doing something
another edit
When I enabled support multi sites in sensitive settings, within hashover/comments/ it created me a folder for my domain name. When i add comments to that folder, the notification emails have the correct domain set in the email subject and body. Before i enabled multisite, my comments were all going in /comments/threads and the domain was being set to all in the notification emails.
I still have the problem with the blank {title} in the emails. There is a <title> tag in the source and the hashover functionality to say comment on "blah title" was picking it up, so weird one.
edit
changing the mail delivery method from smtp to sendmail has fixed the title issue. I also didn't realise i wasn't getting email notifications.
Hello @mmelon. The domain saying all was caused by a previous commit, bc6ecde. It seems the solution I applied was too simplistic. I will push a commit to fix the issue shortly. It would be great if you could test it.
As for the title being blank, I have no idea why that would be happening, especially with it only happening using SMTP, as the data sent through SMTP and sendmail is the same. How were you seeing the notification emails if you weren't getting them?
Hi. Cool thx for the fix. Let me know and i will test for sure.
With the notification emails, it's probably a mail server misconfig. When I use sendmail, it all works nicely. When I use SMTP, i get replies to commenters sent, but no notification emails to the admin address. I confirmed by checking the log in cpanel. Oh and the blank [title] in the email subjects and bodies. weird.
I made the changes, the issue should be fixed. Please test it and let me know.
domain seems to work now with multisite turned off. I only updated writecomments.php. nice one.