jaegertracing/jaeger-client-python

Unable to validate config with max_operations

phaero opened this issue · 0 comments

Requirement - what kind of business use case are you trying to solve?

Trying to set max_operation in configuration

Problem - what in Jaeger blocks you from solving the requirement?

Validate config throws an exception if max_operations is present in configuration:
INFO:config {'sampler': {'type': 'const', 'param': '1'}, 'local_agent': {'reporting_host': 'localhost', 'reporting_port': '6831'}, 'max_operations': '0', 'logging': True}
Traceback (most recent call last):
File "/test.py", line 115, in
tracer = initialize_tracer()
File "/test.py", line 106, in initialize_tracer
validate=True)
File "/usr/lib/python3.6/site-packages/jaeger_client/config.py", line 98, in init
self._validate_config(config)
File "/usr/lib/python3.6/site-packages/jaeger_client/config.py", line 136, in _validate_config
format(','.join(unexpected_config_keys)))
ValueError: Unexpected keys found in config:max_operations

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add max_operations as a valid key in _validate_config.

Any open questions to address