[Bug]: Archive button is enabled by default
ViliusS opened this issue · 7 comments
What happened?
Not sure if this a bug in the UI or in the Jaeger itself, but we have upgraded our Jaeger instances controlled with Jaeger Operator from 1.51 to 1.54. This updated UI from 1.35 to 1.38. Now on at least all-in-one configuration Archive button is enabled by default.
Steps to reproduce
- Install Jaeger Operator 1.54
- Use this simple YAML to deploy the instance:
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
name: jaeger
namespace: default
spec:
strategy: allInOne
allInOne:
options:
query:
base-path: /
ingress:
ingressClassName: nginx
hosts:
- yourhost.example.com
pathType: Prefix
storage:
options:
memory:
max-traces: 100000
Expected behavior
Archive button should be disabled by default, as per documentation.
Relevant log output
No response
Screenshot
No response
Additional context
It is probably due changes in #1944.
Jaeger backend version
1.54
SDK
No response
Pipeline
No response
Stogage backend
memory
Operating system
No response
Deployment model
Jaeger Operator for Kubernetes
Deployment configs
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
name: jaeger
namespace: default
spec:
strategy: allInOne
allInOne:
options:
query:
base-path: /
ingress:
ingressClassName: nginx
hosts:
- yourhost.example.com
pathType: Prefix
storage:
options:
memory:
max-traces: 100000
why is it a problem? The button now reacts to the capability of the underlying backend, if archive is available (as it is with Memory store) then the button shows. I believe there is a UI flag to turn if off.
I don't think that that turning on archive button for in-memory backend is correct. The idea that trace can be archived implies that it will be stored permanently. For in-memory backend archived traces won't be persistent between Jaeger restarts though.