[jaeger-v2] Add Meter Provider To Telemetry Settings
Closed this issue · 5 comments
mahadzaryab1 commented
Requirement
We're currently using no-op meter providers in the code instead of propagating the provider from OTEL. To change this, we need to do the following:
- Add OTEL's meter provider to https://github.com/jaegertracing/jaeger/blob/main/pkg/telemetery/settings.go#L16-L22
- Propagate this setting to places where
noopmetric.NewMeterProvider()is used
akstron commented
Hi @mahadzaryab1 we should be adding LeveledMeterProvider instead of MeterProvider right? as I see MeterProvider is deprecated.
mahadzaryab1 commented
@akstron yes that’s correct!
yurishkuro commented
Still see two more places in non-test code
$ rg noopmetric.NewMeterProvider
cmd/collector/app/handler/otlp_receiver.go
77: return noopmetric.NewMeterProvider()
79: MeterProvider: noopmetric.NewMeterProvider(),
cmd/collector/app/handler/zipkin_receiver.go
71: return noopmetric.NewMeterProvider()
73: MeterProvider: noopmetric.NewMeterProvider(),
mahadzaryab1 commented
@yurishkuro Those are in the context of v1 - can we do anything there?
yurishkuro commented
Fair enough, we can close this.