Remove version number in files

Question

Remove version number in files

Closed this issue 10 years ago · 4 comments

I think the version number should be removed from composer.json and DropboxUploader.php. Lets just have the version bump when you make a new tag for packagist.

Answer 1 · 2015-01-22T07:16:16.000Z

Hi @jongotlin, for which reason? - Edit: I see your PR now, I guess you mean for practical reasons of a PR, right?

Answer 2 · 2015-01-22T14:26:10.000Z

Yes. And to follow the standard to have the version number in a git tag commit. Having both is just confusing.

Answer 3 · 2015-01-22T23:29:44.000Z

For the composer.json I'm with you, for the source file I think it's useful to keep that in. In #50 I've removed it from composer.json.

And there is no need for PRs to bump the version, I normally do that on my own, the version bump commit is the change-log as well.

Answer 4 · 2015-05-22T05:51:35.000Z

@jongotlin I close the issue, feel free to re-open at any time.