Only one issue to resolve to add support for IE 7 and 8

Question

Only one issue to resolve to add support for IE 7 and 8

Closed this issue 12 years ago · 11 comments

jakiestfu commented 12 years ago

Please read the article here: http://www.sitepoint.com/line-endings-in-javascript/

I cannot seem to get rid of the \r\n line ending in javascript.

The issue: On IE 7 and 8, a single newline has a length of 2 if within a textarea. Throws everything off.

SitePoint goes over a way around this but I cannot figure a way to implement this.

EDIT: More information

Setting the Caret position is OK, retrieving the actual value is wrong, see here:

http://jsfiddle.net/jakie8/xpD99/

Answer 1 · 2013-01-26T01:32:53.000Z

I have setup a fiddle of the demo to start playing with this:

http://jsfiddle.net/F7FPG/

Answer 2 · 2013-01-26T01:54:51.000Z

My bad. I assumed jsfiddle worked with IE8. I loaded the fiddle in VirtualBox (I'm on OSX) and discovered it does not. Sorry about that.

Answer 3 · 2013-01-26T01:55:52.000Z

No, it's all good.

Currently, I am thinking of an approach by measuring the newline characters length and then offsetting the carat get/sets by appropriate amounts, but it's still really tricky.

Answer 4 · 2013-01-26T02:21:27.000Z

Cool and good luck. Nice work on this by-the-way. I love it.

Answer 5 · 2013-01-26T10:34:10.000Z

What exactly is your problem with the different line breaks?

Answer 6 · 2013-01-26T16:25:50.000Z

@Paratron The issue is IE 7/8 use \n\r as a line break instead of \n. So if you were to press enter on an empty textarea, you'd expect the values length to be one, but IE7/8 has a value of 2. This messes things up all around.

I was thinking about stripping the \r via the utils.editor.get method, but still, when I set everything, (data and carat), the carat is set in the wrong place.

Answer 7 · 2013-01-26T21:13:15.000Z

@jakiestfu I have a partially working fix in my fork, but utils.cursor.set is still causing issues. I have the tab and multiline tab working properly.

Answer 8 · 2013-01-26T21:54:58.000Z

@birla I see you're trying to fix the get caret issue.

I tried implementing it in a much simpler fashion, and it still did not work. Try messing with this fiddle and see if you can figure out how to fix this! Thanks for your help!

http://jsfiddle.net/jakie8/xpD99/

Answer 9 · 2013-01-26T23:15:52.000Z

@jakiestfu I took a shot at the fiddle and I was able to fix getting the caret position in all cases except when it's at the beginning of a new line.

http://jsfiddle.net/xpD99/1/

Answer 10 · 2013-01-26T23:39:21.000Z

@birla http://jsfiddle.net/jakie8/kreQP/5/

Type in a brace (which should give you an open and close), then keep pressing enter. For every time you press enter, the cursor's get position is incremented by one. I believe fixing that would also fix the issue with it at the newline. Any ideas? Thanks so much for your help!

Answer 11 · 2013-01-27T04:27:38.000Z

I have completed _full support_ for IE 7 and 8. Will push later tonight after cleaning it up a bit. Thanks for all of your help everyone!