jakke-korpelainen/newtab-angular

Additional translations

jakke-korpelainen opened this issue ยท 7 comments

If a translation is missing for your language, feel free to contribute ๐ŸŒŽ!

Added Traditional Chinese 93e60f4 (Thanks to @kevinjcliao)

I'd like to throw some German translations in. However with the current structure it is not really possible since 'Good evening' is 'Guten Abend' however 'Good night' is 'Gute Nacht'. If you would like to have German translations, the model would need to be updated.

@vanniktech Ok great! It's sort of possible like this without changes into models;

{
    "morning" : "",
    "afternoon" : "",
    "day" : "",
    "evening" : "Guten abend",
    "night" : "Gute night",
    "good" : "",
    "today" : "",
    "is" : "",
    "greeting" : "{daystate} {name}, today is {date}"
}

Isn't a best practise so I'll try to come up with a more sophisticated solution.

Should I wait for you to make some changes or should I create the German translations and create a PR?

Feel free to create a PR, I'm going for a holiday tomorrow so I'll refactor the translations later this month :).

There you go #25

Merged, thanks!