jakubzet/mailspring-matcha-theme

Toolbar color bug on Mailspring 1.9.2 Windows

Rayjjn opened this issue · 6 comments

Rayjjn commented

Hello ! I'm loving your theme but i'd like to report an issue.
I installed the theme on Mailspring 1.9.2 on Windows and the toolbar (i believe it's the name on this element) is white instead of dark.
I ran a bit into the sources and i think that Mailspring on Windows might not have the same ui variables as Linux.
Here is a screenshot :
bug_matcha

Thanks for the good work !
Regards

jakubzet commented

Hi Rayjin, and thank you for reporting the issue! I'll do my best to check the reason of this on Windows - however, currently I don't have an access to any Windows machine, as I mainly work on Linux Manjaro.

Nonetheless, I'm keeping the issue open, so as soon as I have an opportunity to use Windows, I'll check things out.

wituwitu commented

I also have this problem on Windows. Is there any update? I also noticed that in the theme selection screen, the modal-close.png button is not found, this may give more hints on what's happening. I really like the style of this theme but can't use it :( !

imagen

I think this issue also overlaps with this one, I have the same problem as well.

jakubzet commented

@wituwitu - unfortunately, I don't have an access to Windows PC, as I use Linux Manjaro on a daily basis.
As soon as I'll have time I'll try to install a virtual machine of some kind and test the theme there.

Safibulae commented

@wituwitu - unfortunately, I don't have an access to Windows PC, as I use Linux Manjaro on a daily basis.
As soon as I'll have time I'll try to install a virtual machine of some kind and test the theme there.

Were you able to look into this Windows bug? Many thanks in advance!

Vaniom commented

Hello @jakubzet ,
Nice theme, I love it!
I also noticed a bug color on the .sheet-toolbar-container
I fixed it by adding the following rule to index.less (yes, I am to lazy to find the correct component file :p)

body.platform-win32 .sheet-toolbar-container,
body.platform-win32.is-blurred .sheet-toolbar-container {
      background-color: @base_color_dark;
}
  • 👍1
Safibulae commented

Hello @jakubzet , Nice theme, I love it! I also noticed a bug color on the .sheet-toolbar-container I fixed it by adding the following rule to index.less (yes, I am to lazy to find the correct component file :p)

body.platform-win32 .sheet-toolbar-container,
body.platform-win32.is-blurred .sheet-toolbar-container {
      background-color: @base_color_dark;
}

You, Sir, are the MVP. THANK YOU!!