jamespacileo/django-pure-pagination

No margin pages?

Opened this issue · 3 comments

typeshige commented

Can you turn off margin pages, so it only shows the middle part? Setting MARGIN_PAGES_DISPLAYED to 0 or None doesn't do what I expected...

Also, I seem to be able to get it to work in generic class based views by setting:

paginator_class = Paginator

where Paginator is

from pure_pagination import Paginator. You had mentioned support for generic class based views via a mixin and I was wondering if you were going to do more than just swap out the Pagination class.

Thanks,
Shige

jamespacileo commented

I will have a better look at this, thanks for the raising the ticket.

jamespacileo commented

Incrementing PAGE_RANGE_DISPLAYED to a high number should solve the problem temporarily.

I will apply a fix soon.

UncleVasya commented

If anyone interested I made a PR solving this: #36

For future readers.

If PR still not merged but you wanna have this fix, you can use my fork.
Just replace

django-pure-pagination==0.3.0

with

git+git://github.com/unclevasya/django-pure-pagination.git@disablable_margins

in requirements.txt