jamessimone/gatsby-remark-footnotes

Add MDX support

Opened this issue · 8 comments

When used in remarkPlugins, footnoteBackRefInnerText in the options does not seem to work when used with gatsby-plugin-mdx.

I did not put it in gatsbyRemarkPlugins because the footnotes are rendered just below where they were used, and not at the bottom of the page.

Could you please add support for that?

What order are the plugins listed in your gatsby config in the remark plugins list? Does putting gatsby-remark-footnotes above gatsby-plugin-mdx help?

Putting it above gatsby-plugin-mdx would "work", but options are not working.

About the position of the plugin: I had put it at the very end of remarkPlugins and options did not work.

When I was trying with gatsbyRemarkPlugins, it was at the bottom of the array. However, the footnotes were generating not at the very bottom, but right below where they are used.

Got it. If you can provide a minimum reproduction repo, there's a chance I'll be able to debug this at some point. Sorry that it doesn't sound more promising than that, but I'm afraid I don't use gatsby-plugin-mdx personally and I'm a bit swamped with work at the moment.

Of course, I would happily welcome a PR if you're up for it!

Today is the first time I used MDX, so even I can't debug it, as of now. I will push the code soon and share the repo link here. After seeing the repo if you find where things are going wrong, just nudge me, I would try to tackle it.

Hi, the code is available here: https://github.com/acagastya/gatsby-test

The revision which implements MDX properly is: acagastya/gatsby-test@6180ce0

tony commented

@acagastya Would you like to make this change into a PR?

@tony Thank you for pinging. It has been many months and I don't remember much about this. Let me have a look.

tony commented

@acagastya No pressure! Thanks for the quick response!