Suggestion to change code in match_idf_surfaces function
Opened this issue · 3 comments
I was testing intersect_match function using simple 2 boxes stacking vertically which has adjscency between roof and floor. However, all the outside boundary condition set to outside which implies this API is not working properly. After investigation, I found that if I change following code to suggestion code in match_idf_surfaces, the problem is fixed.
I understand intension in original code but suggestion code could widen the case which caught by this if sentence.
What do you think about this revision and if you have some intension to keep original code, I would like to know.
Original code.
if almostequal(s.coords, reversed(m.coords)):
.
Suggestion code.
if almostequal(sorted(s.coords),sorted(m.coords)):
Happy to take a PR with a test case. Thanks for the suggestion.
This new update is available on which version of geomeppy? My version is 0.11.8. The problem is still there.
Great fix @katsuya0719