jamoma/JamomaCore

Comparison of 2 TTSymbol inside TT_ASSERT is casted in TTSymbol

Opened this issue · 5 comments

here the line :

TT_ASSERT("TTTimeCondition::EventStatusChanged : status effectively changed", newStatus != oldStatus);

I can't give more detail for now but I'll try to give a test.

tap commented

Assigning back to you @theod for clarification, as I don't understand what this means.

Here a simple test to make the test failed (I've try by adding theses lines into an existing test) :

TTSymbol a("a");
TTSymbol b("b");
TT_ASSERT("TT_ASSERT do strange stuff with the following expression", a != b);

It should failed to build.

I mean the test executable should not pass due to crash when going into the TT_ASSERT.

tap commented

I think I do not understand. "a" is not equal to "b", so therefore "a !=
b" is true and the assertion passes (as it should). So maybe I need some
more info or a little test program or something?

Tim

On Mon, Dec 22, 2014 at 10:48 AM, theod notifications@github.com wrote:

I mean the test executable should not pass due to crash when going into
the TT_ASSERT.


Reply to this email directly or view it on GitHub
#321 (comment).

I've created a fix/321 branch to allow you to test it.
as you will see when you'll build Core, Foundation library fails now for a very strange reason (as far I remember the boolean result was casted into a symbol or something like that …).