janboddez/share-on-mastodon

is_int instead of ctype_digit

Closed this issue · 1 comments

janboddez commented

I think in, e.g.,

share-on-mastodon/includes/class-block-editor.php

Line 117 in de90a8a

if ( empty( $post_id ) || ! ctype_digit( (string) $post_id ) ) {
we can simply move to is_int as it's a REST API only thing and JSON, unlike form requests, will give us an integer rather than a string.

janboddez commented

Turns out this isn't true, at least not always.