Standalone ppx rewriter (-as-ppx mode) ignores cookies
Closed this issue · 3 comments
copy commented
This causes janestreet/ppx_inline_test#1. ppx_inline_test creates error nodes in the ppx if the build system doesn't specify a library name. jbuilder generates a proper -ppx flag for merlin including the --cookie library-name=… part, but this driver ignores cookies when in -as-ppx mode (--cookie is in standalone_args when it should be in shared_args).
Deleted user commented
Indeed, I fixed this in the v0.10 branch, we are going to do a new release soon
Deleted user commented
yes