Missing test dependency from magic-trace.opam ?

[erenon]

I tried to build the project using:

$ opam install .
$ make default

And got:

File "test/sample-targets/variable-duration/dune", line 3, characters 27-43:
3 |  (libraries core core_unix ocaml_intrinsics magic_trace)
                               ^^^^^^^^^^^^^^^^
Error: Library "ocaml_intrinsics" not found.
-> required by
   _build/default/test/sample-targets/variable-duration/variable_duration.exe
-> required by alias test/sample-targets/variable-duration/all
-> required by alias default

Should ocaml_intrinsics added to the project as a with-test dependency?

[Xyene]

That sounds right. Would you be willing to send a patch?

[erenon]

Probably this was something to do with my environment, since it builds in CI. The patch btw could be:

diff --git a/magic-trace.opam b/magic-trace.opam
index 696238c..8ad0784 100644
--- a/magic-trace.opam
+++ b/magic-trace.opam
@@ -25,6 +25,7 @@ depends: [
   "owee"         {>= "0.6"}
   "re"           {>= "1.8.0"}
   "zstandard"
+  "ocaml_intrinsics" {with-test}
 ]
 synopsis: "Collects and displays high-resolution traces of what a process is doing"
 description: "https://github.com/janestreet/magic-trace"