janestreet/magic-trace

Filter events from after the stop indicator

Opened this issue · 2 comments

Magic-trace doesn't stop recording exactly when the stop indicator is hit. That can be quite confusing, especially if you get unlucky and the stop event is nowhere near the right hand side of the trace.

To fix this, let's filter out events from the trace that happen after the stop indicator returns.

It's conceivable that people will want the current behavior behind a flag, but I weakly think it's not worth the extra UI complexity.

Looks like this could be useful: search man perf-record for "tracestop". I think it might end up as a message in the perf script, so if we use this we'll need to filter that message out.

Xyene commented

Ref also -immediate-stop from #79.