A slide can be skipped even if navigation is blocked
tutaf opened this issue · 1 comments
tutaf commented
A long swipe skips slide that should be unskippable
Reproduce
Steps to reproduce the behavior:
- Open demo app (or other app with this library)
- Click on "start intro"
- Scroll to an unskippable slide (eg. permission request or login)
- Long swipe several times
- Slide is skipped
Expected behavior
The slide shouldn't be skipped
Stack trace / screenshots
MNML-January3-113943PM.mp4
Device
Asus Zenfone Max Pro M1 (Android 10), demo app v.1.6.1 (same problem in library v.2.0.0)
Emulator (Pixel 3a, API 30) library version v.2.0.0
janheinrichmerker commented
This is a glitch which I was not able to fix in ViewPager, as the stock ViewPager API does not support blocking swiping. Thus I had to block swiping using touch listeners. I would be happy to merge a PR in that regard, but I don't have the time to re-implement blocking of sliding. Maybe the library needs to be re-written with ViewPager2...
PS: Turns out, GitHub quick-tips just told me you can upload MP4 and MOV files by drag & drop.