Bad case in Basic example

Question

Joey777210 opened this issue 2 years ago · 4 comments

Hi, I'm new to janino, and try to get some example on homepage. But there is a ambiguous reference of the first example:

Run that code on JDK1.8, it gives ambiguous reference.
This can be a bad guide for beginners, maybe replace with another case?

Answer 1 · 2023-04-20T12:05:58.000Z

See this two functions:

Answer 2 · 2023-04-20T12:09:53.000Z

And also, how can I use evaluate on pure int type expression?

Answer 3 · 2023-04-30T21:56:37.000Z

That example code doesn't work since Janino 3.0.16, when I changed the signature of

org.codehaus.commons.compiler.IExpressionEvaluator.evaluate(int idx, @Nullable Object[] arguments)

to

org.codehaus.commons.compiler.IExpressionEvaluator.evaluate(int idx, @Nullable Object... arguments)

, assuming that this is a compatible API change. (As you proved, it is not.)

Because it is not easily possible to revert that API change without breaking application code, I fixed the code example instead.

Thank you for reporting the problem! Please re-test.

Answer 4 · 2023-05-09T01:42:55.000Z

That looks fine, Thanks.