jankrib/ha-xcomfort-bridge

Make Identifier field voluntary and fix the readme

Closed this issue · 5 comments

This field is useful for those who care about unique ids. It should be easy to skip, though. And the way it's described in the readme doesn't make sense.

Feel free to add to the issue @skela, since it was you that introduced it.

skela commented

Yeah it's just a nickname or reference. Useful for some, I like being able to name my things so 😂

It was meant to be optional sure, I thought it defaulted to use the ip address if missing.

skela commented

Although having the ip as a fallback identifier is pretty awful if I think about it.

Maybe it could default to "XComfort Bridge" unless identifier is supplied?

"XComfort Bridge" makes sense as a default.

Fixed this is the last build