implement std::collections
Closed this issue · 5 comments
I think most of would be simply re-exporting the stuff from the collections crate (modulo collections::HashMap which is covered by #4)
HashMap and HashSet depend on thread_local!
HashMap and HashSet can (and, IMO, should) be implemented without thread_local! by reverting the last change that added that dependency back.
What was that change, and why do you consider it bad?
It's probably easiest to stay in sync with mainline Rust.
It was rust-lang/rust#37470. You can read rust-lang/rust#36481 and the other issues regarding this and arrive at your own conclusion regarding the merits and demerits.
If you revert that then you can see how you can easily replace thread_local! with lazy_static!. That might not be a big enough win to justify forking, if you're planning to have thread_local! soon. lazy_static! is easier to implement.