ordinal: produces different results for decimal-as-string compared to decimal-as-float input
jayaddison opened this issue · 2 comments
jayaddison commented
Expected behaviour:
>>> from inflect import engine
>>> p = engine()
>>> p.ordinal(5.502)
'5.502nd'Actual behaviour:
>>> from inflect import engine
>>> p = engine()
>>> p.ordinal(5.502)
'5th'Possible cause:
- The logic to determine the number to map a decimal to an ordinal is bypassed when the input is a
float.
Discovered by chance while adding test coverage related to ordinals for decimal numbers (if I'd represented the decimal by using a string, then I wouldn't have found this).
jayaddison commented
Possible cause:
That's not all:
pydantic's validation appears to read the num: Union[int, Word] argument from the method signature and uses it to coerce the resulting num variable to type int.
If that's the case, then the ordinal method likely does not handle many float inputs correctly.
A possible fix could involve adjusting the method's signature, and/or adjusting the type hints:
@validate_arguments(config=dict(arbitrary_types_allowed=True)) # noqa: C901
def ordinal(self, num: Union[Number, Word]) -> str: # noqa: C901Todo: confirm that this is true, and then provide relevant feedback on the pydantic issue tracker.