Links should have title attributes
Closed this issue · 3 comments
jaredatch commented
.ea-share-count-button links should have title attribute.
Basically title="Share on {$service}" or similar.
billerickson commented
I started by doing title="Share on ' . $link['label'] but we end up with "Share on Tweet" and "Share on Email".
I think a better approach is to add another parameter to $link called attr_title or something similar. This way we can customize each link's title text, and it's filterable using the ea_share_count_link filter.
jaredatch commented
I think that's a good idea. Looks solid to me 👍