jasmcaus/tau

CHECK with message doesn't work

GibbOne opened this issue · 9 comments

GibbOne commented

First of all I'd like to thank @jasmcaus for this useful library.

So, I found out a little problem with custom failure message.
According to documentation it's enough to add a further parameter. But If I add a parameter, the check never fails.

Below an example.

TEST(TAU, ItShouldFailWithMessage)
{
    CHECK(0);                           // this check fails correctly.
    CHECK(0, "It should FAIL");         // this check doesn't fail.
}

Am i missing something?

jasmcaus commented

@GibbOne I ran this locally, and it seems to work:

image

Try this in a test file:

#include <tau/tau.h>
TAU_MAIN()

TEST(TAU, ItShouldFailWithMessage)
{
    CHECK(0);                           // this check fails correctly.
    CHECK(0, "It should FAIL");         // this check doesn't fail.
}
GibbOne commented

@jasmcaus if I use gcc it works like you did. But if I use MSVC, it doesn't.

image

jasmcaus commented

@GibbOne See this. Only MSVC 2017 seems to fail. Not sure why. I don't have a Windows machine w/ me so it's quite hard for me to explore this. Would you mind taking a look and opening a PR with your changes?

jasmcaus commented

@matu3ba maybe you could have a look at this as well?

matu3ba commented

Let me spin up Windows in a WM to see, if I can reproduce.

// file t1.c
#include <tau/tau.h>
TAU_MAIN()

TEST(TAU, ItShouldFailWithMessage)
{
    CHECK(0);                           // this check fails correctly.
    //CHECK(0, "It should FAIL");         // this check doesn't fail.
}

// file t2.c
#include <tau/tau.h>
TAU_MAIN()

TEST(TAU, ItShouldFailWithMessage)
{
    //CHECK(0);                           // this check fails correctly.
    CHECK(0, "It should FAIL");         // this check doesn't fail.
}

// windows cmds:
// cl /I . t1.c -o t1
// cl /I . t2.c -o t2
// linux (works)
// gcc -I . test.c -o t1 && ./t1
// gcc -I . test.c -o t2 && ./t2
matu3ba commented

@GibbOne Please always provide version numbers for the compiler version.

On the latest? release 19.13.31105 I get with cl /I tau t1.c with t1.c having the following content:

// file t1.c
#include <tau/tau.h>
TAU_MAIN()

TEST(TAU, ItShouldFailWithMessage)
{
    CHECK(0);      // this check fails correctly.
    //CHECK(0, "It should FAIL");           // this check doesn't fail.
}

the following error:

tau\tau/misc.h(34): fatal error C1083: Cannot open include fils: 'inttypes.h': No such file or directory.

So to me it looks like tau is broken on MSVC.

GibbOne commented

@matu3ba I already showed MSVC compiler version on my last post. Look at picture of console.

  • 👍1
matu3ba commented

@GibbOne My bad.

At least this post indicates that Microsoft only guarantees compatibility via their libraries.
https://stackoverflow.com/questions/41975672/abi-compatibility-of-visual-studio-c-libraries

A proper fix would probably require https://stackoverflow.com/questions/9233118/library-abi-compatibility-between-versions-of-visual-studio with https://github.com/lvc/abi-compliance-checker to figure out what is broken,
since unfortunately Microsoft does not generate reports what stuff they broke how and when.