jasoncostello/slate

Where should pull requests be sent?

IQAndreas opened this issue · 4 comments

IQAndreas commented

I started working on a pull request, but noticed the CSS for this theme is slightly different than the one currently used by GitHub Pages.

Should pull requests be sent here, or is there a separate public fork of the theme used by GitHub pages?

jasoncostello commented

@IQAndreas You can send PRs here. These are different files but I can update the GitHub theme.

IQAndreas commented

It's a tiny fix, but I would recommend adding :focus wherever :hover is used (and I would be happy to create a pull request instead of just mentioning it if it makes it easier for you):

Also there's a set of blank lines between lines 168 and 170 in the GitHub Pages version which don't actually make a difference, but still annoy me whenever I scroll past them. ;)

jasoncostello commented

I recently pushed some updates that should have cleaned up the whitespace for both this version and the generator version on GitHub.com.

Regarding :focus, it's declared with :hover for <a> in my styles. Let me know if I missed it somewhere.

cheers!

IQAndreas commented

Regarding :focus, it's declared with :hover for <a> in my styles.

Right you are, I didn't see that it was fixed in 9424d3c. It's a shame those fancy hover transitions were removed though. ;)

Let me know if I missed it somewhere.

On the GitHub Pages template, the "Download ZIP" and "Download TAR" are missing it and still don't react when you tab over them, but I'm not sure if that's indented or not: https://github.com/IQAndreas/temp/blob/gh-pages/stylesheets/stylesheet.css#L347

Otherwise, it looks great, thanks!