jasonleibowitz/react-add-to-calendar-hoc

buttonProps does not take an onClick function. Allow handling of dropdown toggle in the props.

its-segu opened this issue · 0 comments

its-segu commented

Bug Report

buttonProps does not take an "onClick" function

Describe the bug

I have consecutive events you can add to a calendar. If a user opens another 'Add to Calendar' dropdown, any other opened ones should close.

I was attempting to pass an onClick function to buttonProps, but the button is overwritten by another function in your code: onClick={this.handleDropdownToggle}. Please allow the toggle to be passed as a prop, and maybe also allow for the button prop to accept an onClick prop as well.

To Reproduce

Map multiple events to AddToCalendarDropdowns. Notice dropdowns do not toggle based on "active" component.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

  • OS: macOS
  • Browser chrome
  • Version of Library: Latest

Additional context

Add any other context about the problem here.