jasonromulus/charity2

Feedback

Opened this issue · 0 comments

Excellent work on this project. I can tell you really took advantage of this opportunity from the project’s completeness and the commit history shows you’re gradual development of it as a project. Great work. I especially liked your use of the handlebars moment helper, and the clean resourceful routing.

For a challenge you could also refactor this project to use async and await to resolve your promises—advanced ES7 functionality. An example looks like this:

// COMMENTS#EDIT
router.get('/comments/:id/edit', async (req, res, next) => {
  let comment = await Comment.findById(req.params.id).populate('sbar')

  res.render('comments-edit', { comment: comment })
});

Now you've got the fundamentals of web development, don't hesitate to jump into something ambitious.