jasonwilliams/vscode-helix

Entering insert mode with 'i' does not clear the selection

HesamR opened this issue · 7 comments

HesamR commented

if you have something selected in normal mode or visual mode and press 'i' to enter insert mode it keep the selection active which if I'm not mistaken is not helix behavior.

version reported in vscode : 5.5.0

jasonwilliams commented

I don't understand what you mean @HesamR can you show me a screenshot or a recording? When i select something in Helix and press I i still get the selection

HesamR commented

helix does keep the selection active in insert mode but when type it does not replace and delete the selection

helix.mp4
vscode.mp4
JackWolfard commented

I also have this issue. The behavior is similar to change_selection which by default is c. I expect insert_mode which by default is i to insert before selection without any deletion.

jasonwilliams commented

Hmm this one is tricky, I don't know if there's a solution. If you highlight text in code and type it will replace the selection, its a core VSCode thing, I don't think that behaviour can be changed with extensions. The only option would be to try and remove the selection when you hit "i"

jasonwilliams commented

I think I’m going to try removing selections on “I”. This won’t match Helix’s UX but it will prevent the bug @JackWolfard is showing. How often do people go into insert mode but keep the selection alive, is this a common use case?

HesamR commented

I don't think so. I been using helix for 2 years as daily driver and I never noticed it keep the selection when you enter insert mode.

jasonwilliams commented

So this has been fixed but I've realised it should be inserting before the selection regardless of where the cursor is and 'a' should always insert after the selection.

I'd be keen for some contributions to this as to help out, this should be a good first issue if either of you wanted to take it