[FEATURE] Have 100% of test coverage
jaswdr opened this issue · 5 comments
Is your feature request related to a problem? Please describe.
This is an improvement on our current test coverage.
Describe the solution you'd like
Recently we have added the test coverage report, considering that this project is focused in generate fake data for tests, is good to have 100% of test coverage.
Describe alternatives you've considered
For normal projects, it's common knowledge that 100% don't guarantee quality, but in this case this project is focused on tests, so is important to us to have at minimum a good test coverage.
Additional context
The confirmation that we reach this goal is having 100% in coveralls
Important! Use the full-tests-coverage branch as target of pull requests.
Would you prefer to have these on one big PR? I took a quick glance at what's missing but I'm not sure how big the end change would be. Also, I would like to start working on these but I would also like to have a better control on what's taken and what's not in case more people wants to collaborate.
@ab22 I guess one approach that we can do to split the work is to fix each file individually, doing PR's for each file adding a 100% coverage for only that one.
what you think?
Sounds good 👍. I will start with the person.go tests in that case and will keep calling out which file I'm picking up.