Integrate crate-metadata fork

Question

Integrate crate-metadata fork

Opened this issue 6 years ago · 6 comments

facboy commented 6 years ago

Are there any plans to integrate the changes in https://github.com/crate-metadata/json-patch?

Answer 1 · 2019-09-04T22:30:38.000Z

I merged the json-schema ones. Happy to merge a PR that copies them over.

Answer 2 · 2019-09-04T22:31:26.000Z

The only wrinkle is I'm not sure if we diverged from the spec at all with those patches.

Answer 3 · 2019-09-05T14:22:08.000Z

hmm...how can you tell?

Answer 4 · 2019-09-05T16:55:45.000Z

I probably just have to look through. Was there any particular patchset you wanted pulled forward?

Answer 5 · 2019-09-06T13:50:22.000Z

hmm...at the moment we are dependent on some of the introduced operations, though whether we actually use them in practice, i'm not sure.

Answer 6 · 2019-09-06T17:11:48.000Z

after some tidy up i think we can return to using this library without the crate-metadata changes - now that this is being maintained i suspect it's better to stay closer to the RFC standard without the extra operations. were there any bug-fixes or improvements on the fork that aren't related to the extra operations?