java-war/dellroad-stuff

Add support for Vaadin Touchkit and Spring in Tomcat 6

Closed this issue · 3 comments

Hi 
I am writing a small Vaadin Touchkit App with Spring integration. I used the 
addon spring-touchkit 
(https://vaadin.com/directory#addon/spring-touchkit---addon:vaadin) which uses 
your SpringContextApplication class.

In this I had a problem to use it in tomcat 6 (tomcat 7 is fine).
So I had to patch the class SpringContextApplication to retrieve the 
servletContext in the catch Block at line 331 (Dellroad Version 1.0.592).
I attached a patch file. Maybe you could apply this to your project or add my 
changes as another try catch block.

Regards
Ansgar


Original issue reported on code.google.com by ans...@schulte.com.de on 31 Jan 2013 at 2:41

Attachments:

Thanks.

Can you explain why the change from servletContext.getContextPath() to 
request.getContextPath() (last chunk in patch) is necessary?

Original comment by archie.c...@gmail.com on 2 Feb 2013 at 9:38

  • Changed state: Feedback
Hi, 
this last change is only necessary if you have servlet api 2.3 in your 
dependencies. If you have version 2.5 in your dependencies, you don´t need 
this last change. But nevertheless it is also no problem to use request instead 
of servletContext.

Original comment by ans...@schulte.com.de on 2 Feb 2013 at 10:04

Thanks, should be fixed in r623. Try that out and let me know if it works OK 
for you.


Original comment by archie.c...@gmail.com on 4 Feb 2013 at 6:34

  • Changed state: Fixed