Biased bot. Really.
joaquinelio opened this issue · 14 comments
@iliakan
sorry to bother you again, about your kid.
He keeps unchecking these articles,
Perhaps considering they need renaming? (note "\")
@joaquinelio Sure thanks, could you explain in few words what has happened?
just that, 3 translated articles, I check them, then bot unchecks.
I guess it is because of the \ considering they need to be renamed.
No right in the moment I check them, but when "he" goes to edit some other thing,
last time in the moment an article was taken
all at once the bot:
- Added user (@EzequielCaste) to article "indexedDB"
- Removed [X] from 3 articles: (maybe renamed because it erases @ user and # PR too)
-Unicode: flag "u" and class \p{...}
-Word boundary: \b
-Backreferences in pattern: \N and \k
the 3 with a backslash
the 3 from @cortizg , I guess just a funny coincidence
...oops he did it again
@iliakan , Don Bot needs vacation
User mariomenjr took an article,
then Bot modified issue17. Again, in a single update :
-
Added user to the article, OK:
[ ] ArrayBuffer, binary arrays (@mariomenjr) -
Removed [X] from the same 3 articles:
-Unicode: flag "u" and class \p{...}
-Word boundary: \b
-Backreferences in pattern: \N and \k
I know it's him. It's recorded in the issue17 update history.
Though I couldn't get issue history via API.
(Bot is failing in adding PR to the issue too, -mariomenjr Bubbling and capturing #372- but I dont care)
I didn't fix it yet, quite a lot of debugging after putting escapes in.
ah, ok, I though you didnt believe me, sorry =)
it's not a fatal err anyway, I'll put the X X X back.
@joaquinelio I introduced some changes, hope that will fix the problem. But the change is quite deep in the bot code, so let me know if anything's still wrong.
There is a step Mr Bot miss:
Translator claims (valid) - OK
Translator claims (taken) - OK
Translator put a PR - ?
Labeling flow - OK
Maint. merge a PR - OK
The problem started before your big fix, I didn't mind too much.
The important issue is solved 👍
Example:
#374
[The clickjacking attack] | (@homero304) | 2020-09-01 | #374
Edit:
Should it remove "Ready to merge" after merge? Can't say why, unless obsessiveness. Just kidding, nice work =)
@joaquinelio Again, what's the problem exactly?
This looks perfectly fine:
Or did you fix anything manually?
Yes, we do it manually.
The table is valid
Translator claims (valid) - OK
Translator claims (taken) - OK
Translator put a PR - ?
Labeling flow - OK
Maint. merge a PR - OK (with #PR already there)
===
Not an important bug. I commented it just in case you are curious. Or obsessive.
We put it manually just because it is nice to have this tracking,
and Don Bot seems happy to check [X] when we merge.
I dont mind to help Don Bot...
I'd like to fix that.
You mean that when translator puts a PR - nothing happens? Even if the PR title matches the article title?
Exactly.
Thats why I put the verified example.
Other times they dont match case, sometimes the PR is renamed after, so it's ok they miss.
@joaquinelio Thank you. That's because people developing https://github.com/octokit/rest.js/ just LOVE to rename methods with every release. Like no one. A release is failure for them if they don't rename a half of their methods.
I updated the method call name, should work now ;)
Thank you for precise explanations of the errors :)
Experience.
I dont believe users either 🤞