javascript-tutorial/pl.javascript.info

Polish Translation Progress

iliakan opened this issue ยท 100 comments

Maintainer List

@deivuss331, @poplaw, @akowalska622, @Onxi95, @RafalMichniuk

For New Translators

Please read this first (click to open)

To translate an article:

  1. Check that no one else has claimed your article in the checklist below.
  2. Comment below with the title of the article that you would like to translate, exactly as listed, e.g. An Introduction to JavaScript.
    • Please take only one article at a time.
  3. Fork this repo, translate the article in your fork and submit a pull request!
    • The pull request title should be same as the article, e.g. An Introduction to JavaScript (just like comment)

Please be prompt with your translations! If you find that you can't commit any more, let maintainers know so they can assign the page to someone else.

For Maintainers

Click to open

We recommend that a translation has 2 reviews to be merged.

Please let others know what you do, on community boards and chats, invite them to join. Translations become better if more people see them.

Translations are tracked below, like this:

Our helpful bot watches comments and adds the translator nick and PR id, marks completed, when PR is merged. You can read the details at https://javascript.info/translate/bot.

If something doesn't work right, please contact @iliakan.

Team translation

More details about team translation: https://javascript.info/translate/bot.

Only maintainers can check/uncheck items below. If you're not, please write in a comment what you take to translate, the title, exactly as in the list.

The JavaScript language

An introduction

JavaScript Fundamentals

Code quality

Objects: the basics

Data types

Advanced working with functions

Object properties configuration

Prototypes, inheritance

Classes

Error handling

Promises, async/await

Generators, advanced iteration

Modules

Miscellaneous

Browser: Document, Events, Interfaces

Document

Introduction to Events

UI Events

Forms, controls

Document and resource loading

Miscellaneous

Frames and windows

Binary data, files

Network requests

Storing data in the browser

Animation

Web components

Regular expressions

I would like to translate the The modern mode, "use strict"

I would like to translate the Data types

i can translate Document in Browser: Document, Events, Interfaces, starting with Browser environment, specs

I would like to translate Hello World!.

Variables

Interaction: alert, prompt, confirm

Generators

The next for me is Operators and Comparisions

@iliakan @aleksanderkrauze Do you need more "Maintainers"? I can be one. And there are 9 pull requests. We should review pull requests more often.

If no one has started on the Objects topic yet I can translate the first three subtopics : Objects, Garbage collection and Symbol type.

@iliakan @aleksanderkrauze Can we create a Discord or something like that to communicate with each other?

Hi, can I join to this project and help you? :)

I will take Prototypes, inheritance :)

Conditional operators: if, '?'

Hi guys, is this project still alive? 11 PRs, some from July...
Do we have some Slack channel or something?

@bartek7 @mitroc should I assign you as maintainers? Looks like the original maintainer @aleksanderkrauze isn't online any more.

@iliakan Me, a maintainer? Sounds like a VIP :).
But seriously, thanks, but I'm not that good at JavaScript. I will gladly translate some simpler concepts, but I will not undertake to review those that I do not understand myself.

The translation does not have maintainers now, as I see it.

@iliakan Hello there! I'd like to help with translating the docs into Polish.
I'm the main maintainer of Polish translation repo for the official React docs (https://pl.reactjs.org). We've created a glossary there, so I guess I might help with jump-starting the translation process here. You may add me as a maintainer here if you like.
Cheers!

@jakubdrozdek Hey, great to hear from you!

We really need a maintainer here. Added you, invite sent.

P.S. You might want to add the glossary link to the Readme.

@jakubdrozdek We have a bot to ensure double-review of translations. When changes are requested, it adds a label, making PRs easier to filter.

The original bot idea was from react translate bot.

Until we have more reviewers, you can just merge instead of "approving changes". Still, if we get double reviews, that would make the translation quality better.

@bartek7 @JanKesek @Verthon @effhAVE Your PRs are still on the list, waiting for a review or merge. Are you willing to correct any mistakes and will you help with the further translation? Or can I copy/paste your translation and mark the article as translated by you (on the list in this issue). I'm asking because your PRs were created in your forked repos and I can't modify them in any way.

@iliakan Thanks for the explanation. I've got a question: how am I supposed to mark any items on the list as done? I don't have the permission to edit it, and all of the checkboxes are disabled. Any ideas?
In the React repo I had full access to the repo, so I could edit anything.

@jakubdrozdek if a PR was created as a fork of this repo, you can pull the relevant branch and merge it locally, so there's no need to copy-paste.

Did you receive the github invite to join the org? If you did and joined, you have the access.

You're right, it worked :-)
I've just accepted the invitation.

I'll take fetch.

@iliakan Any plans on hosting the pl domain soon?

@jakubdrozdek there's no point in opening pl in its current almost zero-translated state.

@jakubdrozdek Can we use polish here or in reviews comments?

@mitroc Yeah, I think so. It will make our comments better, more precise and more readable, because we won't mix English and Polish. Let's stick to Polish in PRs, and use English in this thread, since it's more 'public' and serves as the progress indicator for people outside. Using Polish in PRs worked fine in React docs, too.

Deal.

Let's wait for PR reviews for max. 7 days to ensure smooth progress. This means that if somebody creates a PR, some other person reviews it and we still need +1 to pass the PR acceptance rules, I (or any other maintainer) will decide if we should merge it after the week or not. We don't want PRs to wait for months just because there are no active reviewers.

Sure. And what about the PRs, that have been hanging here for months?

I'll review them, correct and ask for review again :-)

Oh my...

@jakubdrozdek I guess, right now you can merge PRs single-handedly.

@iliakan I guess you are right. I wanted to 'lure' some more maintainers by allowing them to review my translations, but I will probably gain more by simply pushing the translation progress forward.

What are your requirements for creating the pl domain? Do you want us to reach a particular milestone? Maybe I could prioritize some of the articles in order to reach out to the world sooner.

@jakubdrozdek Surely more maintainers is better, especially with experience from React translation =)

Usually we publish as far as 50% is translated.

At least part 1 is done.

FormData

Guys, this might be a stupid question, but I've almost never made a pull request. Once one PR is in progress I can not make another PR to the same branch, so they are kind of separate? I see that the second PR, which I planned to name FormData was dragged into the first - Fetchm without even giving me the chance to name it... :-/

Yeah, this is because PR is an intent to merge some particular branch into another one. And if you create a PR with branch "X", and then add something else to the same branch, it will appear in the PR, too.

You should stick to those rules:

  • before starting your work, checkout to master branch and pull latest changes - git checkout master && git pull
  • create a new branch from master - git checkout -b new-branch
  • now you may start translating the text, then commit your changes to the branch - git commit -m "my commit message", and then git push

All of those actions can be made with a decent IDE, such as Visual Studio Code.
There might be some differences in your flow since you work on a fork of this repo. The main rule is that each PR should be made with a separate branch.

EDIT: I can see that your PR was created to merge your master into this repo's master.
image
You should avoid making PRs like that and instead create separate branches for each 'feature' (article translation), just like I mentioned above. For now, let's leave it as it is. I'll review your changes and will merge it later. But remember to always create a new branch for each translation :)

EDIT2: Here's a link to an article describing fork flow: https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/. If you remove your local files and do it step-by-step, you should have a properly set up, ready to work local repo and a bunch of good practices in your belt :)

Holy crap! Sounds like I screwed thins up. :), but really I made my last PR in 2017 and it was the third one ;).
Anyway, @jakubdrozdek thanks for the guide, I'think it might be a good idea to pin your post to the repo description for posterity.

Hey, I'd like to translate Comments from Code quality section.

Hello, @sbielenica ;-) Welcome aboard.

Fetch: Abort

Logical operators

Hey guys, I would like to help. I can take a section like Introduction to Events if we can divide by sections. If not I will take an item each time a branch gets in. Up to you!

I want to translate Objects is possible or not?

Methods of primitives

@jakubdrozdek It seems that I've finished working with Methods of primitives. Could I ask you for a CR for this chapter ? I see that I've made this same mistake like @mitroc and tried to merge my forked master branch - sorry for that. For now I will make new branches for every chapter translation.

Conditional branching: if, '?'

Basic operators, maths

"Basic operators, maths" article is translated already, it should be checked. I'll take The "switch" statement then

Introduction to browser events

@kkrawczykpl @Katolus Would you like to work on translations with me ? I think that we still need more people to make some CRs. If you've finished any of translations please make a PR so I can check it.

Nullish coalescing operator '??'

Hi :)
I totally can't find "Nullish coalescing operator '??'"
It should be at 1-js/02-first-steps/12-nullish-coalescing-operator but at 12 - there is while-for.

Am I doing sth wrong or this repo isn't synced with the original?

@sculpt0r Thanks for your vigilance. This repo wasn't sync with the EN version. The 12-nullish-coalescing-operator was missing. I've updated it already. Pull from master branch and start working on 12-nullish-coalescing-operator on new feature branch please.
Good luck! :)

@Moviss In future if you want to be marked in translation progress automatically by bot, please comment like this: Loops: while and for without backticks :)

The "switch" statement

@Moviss In future if you want to be marked in translation progress automatically by bot, please comment like this: Loops: while and for without backticks :)

Thank you - I will remeber :)

Loops: while and for

Arrow functions, the basics

Functions

Error handling, "try..catch"

Objects

Function expressions

Numbers

Object references and copying

Coding Style

JavaScript specials

Object methods, "this"

Arrays

Optional chaining '?.'

Debugging in the browser

@jakubdrozdek @Fjollsfinn are you here? Do you still contribute/review PRs?

@jakubdrozdek @Fjollsfinn are you here? Do you still contribute/review PRs?

No, sorry. I haven't looked here for a long while and I believe I won't continue my work here. Hope you find somebody else ๐Ÿคž

@akowalska622 @deivuss331 @ostafinskim @covalt1985 @Onxi95 @ArturKot95 @poplaw @TheTasak @dwolanin @kplich and others, please let me know if you have enough JS knowledge to review PRs and would like to get maintainership on the repo.

@iliakan JS dev here, glad to review some PRs.

@iliakan yes, I can be a maintainer here.

I can try with pleasure!

Thanks, @akowalska622, added you too for better progress! ;)

Are there still available slots for maintainers? I would like to help :) @iliakan

Ok. Please review each other's PRs. Don't commit just because you can =)

Hey @iliakan, I wanted to review some PRs, but it seems like I can't do it for some reason :(
I mean there's no option in the interface to review, should I have some permissions?

@akowalska622 did you accept the invite letter to join the team?

It must have been sent to your email 11 days ago (right when I added you).

@iliakan I must have missed it!
I found the mail with invitation, but unfortunately it expired after 7 days. Could you invite me again?
I'll check some PRs right away :D

Try visiting https://github.com/javascript-tutorial/pl.javascript.info, do you see a notification with the invite above?
Or https://github.com/javascript-tutorial/pl.javascript.info/invitations.

P.S. If you don't please make a separate issue. As we talk not about translation progress, but rather about your access ;)

Iterables

Error handling, "try...catch"

Custom errors, extending Error

Browser environment, specs

I would like to translate The old "var"

Hi @iliakan
Due lack of time I need to drop my translate assignment of Array section. Cheers!