javascript-tutorial/server

Styles are broken

Closed this issue · 4 comments

smith558 commented

live production (javascript.info):
Image

local dev server:
Image

@iliakan or @amaxcz, any insight on why this is happening?

iliakan commented

There were many subtle changes on the main website branch.

I tried to port them here. Please check now.

  • ❤️1
smith558 commented

There were many subtle changes on the main website branch.

I tried to port them here. Please check now.

Pulled just now. Didn't seem to make much difference.

Image

My suspicion was that this is caused by some recent dependency change due to a missing package-lock.json rather than the actual style sources (I could be wrong). Shouldn't we be able to pull the current package-lock.json from the production? @iliakan, if the styles are working for you locally, would you mind sharing your own package-lock.json so I can reproduce it locally?

smith558 commented

@iliakan works now!

Image

amazing, thanks!

smith558 commented

There are still some subtle differences, but way less important.