image translation
Violet-Bora-Lee opened this issue · 29 comments
Hi, Ilya and the Team!
I've tried to follow the README and tried to translate the images but it's not working somewhat.
Could you check the README?
Chinese contributors also mentioned that they had the same problem.
Hi, thanks for making the issue!
What doesn’t work exactly, could you elaborate please?
Hello?
Hello. I was trying to find the exact cause, but I couldn't find it, so I couldn't leave any more comments.
The same phenomenon happened in the Chinese project, so they translated the svg there right away, so could you follow the README and check if it is reproduced?
Or I think it's not a bad idea to translate SVG files manually. In order to do that, the README file need to be updated
Ok, I just wanted to hear what exactly isn't working. Will ask them then.
Thanks!
This is a snippet of the images.yml, for test:
try-catch-flow.svg:
"Begin":
text: "开始"
position: "center"
"No Errors":
text: "没有 Error"
position: "center"
"An error occured in the code":
text: "代码中出现了一个 error"
position: "center"
"// code...": "// код..."
"Ignore catch block":
text: "忽略 catch 代码块"
position: "center"
"Ignore the rest of try":
text: "忽略 try 代码块中余下的内容"
position: "center"
"Execute catch block":
text: "执行 catch 代码块"
position: "center"
recursion-pow.svg:
"Yes":
text: "是"
position: "center"
"No":
text: "否"
"recursive call until n==1": "递归调用直到 n==1"Thanks!
https://github.com/javascript-tutorial/ko.javascript.info/blob/master/images.yml
Here is the yml file of Korean version
Updated the doc: https://github.com/javascript-tutorial/server#translating-images
The steps should be more clear now. Let me know if you have any questions, please.
I haven't set the dev mode btw.
Is it affect the process of the img translating?
P.S. I've tried on Mac and Windows.
invalid --pretty format? Looks like a git message? Maybe glp is a zsh alias for some git command, not one in the docs?
hmm.. i don't get your comment. Can I get some hint to resolve this issue?
I've googled this error message but couldn't find the hint
Are you using zsh with oh-my-zsh?
Could you please run alias command in the shell and look for glp entry? What's there?
oh, yes i use zsh
and the result is glp=_git_log_prettily
That's exactly what I'm talking about.
In the doc, glp is assumed to be an alias for npm --silent run gulp --.
If you don't want to change the existing alias, you can replace glp with npm run gulp -- in the command.
Thanks to you i resolve the first issue.
But i've encoutered new issue.
I've installed the ImageMagick using homebrew btw.
What could i do to resolve the issue?
Could you try to run the command from the shell? convert ...
command not found: convert
convert is a command from imagemagick. The problem might be with the $PATH.
Please try this? https://apple.stackexchange.com/a/177692
Or try to locate the "convert" utility and see if it's on $PATH.
I've tried my first Mac machine and it's successful!
I'll try on my second Mac which emits errors yesterday and let you know whether your last comment works.
And will try on Windows machine the let you know!
Thanks for your support!
Testing on Windows machine was successful!
One thing I want to suggest is, https://github.com/javascript-tutorial/server#translating-images Step 3's windows command update.
when I execute "NODE_LANG=ko glp engine:koa:tutorial:figuresTranslate" on Windows, the error occurs "glp is not executable command" in powershell & git bash.
so I think it'll better to add Command for Windows, "cross-env NODE_LANG=ko npm run gulp engine:koa:tutorial:figuresTranslate".
I've also tested on Window10 machine again and it was succesful.
I think it'd be better to update README file not using glp but using npm --silent run gulp --
one more to suggest : https://github.com/javascript-tutorial/server#translating-images to check translated svg file on chrome, I had to clear cached image file manually.
It'd be better to add explanation like this : "when Image doesn't translated on refresh, clear your browser's cache file".
Have a nice day! 😄
Thanks, added!
Thanks ilya :)