[Feature Request] Better TAA
Opened this issue · 4 comments
Enabling TAA (Sharp TAA, to be specific) makes distant objects blurry while moving, which makes me feel like I enabled motion blur, which I absolutely despise. Can you make it so that TAA doesn't blur things out in the distance?
I honestly cannot notice the effect you mention to any degree (beyond the inherent smoothing effect of TAA).
I have already adjusted TAA as much as possible to minimize its side effects. If you still believe there's something wrong or perhaps see something different from what I see, please attach an image showing it. Thank you.
I noticed the same thing, mostly when I'm looking at my character while moving in F5 (looking at my face, for example). I saw it happens with other shaders too, I think it's a problem with TAA. Perhaps, something like FXAA would be better? I personally like the "mid spot" between no antialiasing and TAA, would it be possible?
I think he refers to this "issue", check the video, and focus on the face of my character.
TAA.noise.mp4
I’m not really sure if he’s referring to the same thing since he’s talking about a blur.
Regarding the artifact that appears on the character's face: yes, it’s due to the use of TAA combined with certain limitations of the shader mod. It’s not fixable.
TAA works by averaging the current frame with previous frames, but since they’re not identical, certain adjustments have to be made. However, not everything can be adjusted (such as the face). So, the face ends up receiving the same adjustments as the terrain behind it, but since the face doesn’t move and the terrain does, the face constantly tries to adjust even when it doesn’t need to. That’s why it looks like that.
About FXAA: it actually doesn’t work with this shader because many of its effects come from sampling, and without something like TAA, that “noise” looks terrible. It’s the temporal sampling of TAA that masks it. The image that FXAA would process is what you see when you turn off TAA. That “noise” looks awful with FXAA, which is why FXAA isn’t an available option.
I do believe that some improvements with TAA can still be possible. I'm well aware of the heavy lifting TAA does for this shader, and as it attempts to be very lightweight it allows for lower sample counts with less visible noise.
However, certain shaders like Pixel Perfect & Mellow Shaders also use fast TAA techniques but have less blur in motion at the expense of slightly more aliasing (& presumably more noise)
It's personal preference and up to your call at the end of the day, but I would prefer slightly more visible noise & aliasing over the relatively moderate levels of blur in motion that we have currently.
Another idea would be to improve the current sharpening implementation with something like RCAS which is specifically designed to not sharpen noise (it's on AMD's github). I feel like the current implementation causes too much ringing/halo-ing. The sun for example seems to clip rather strongly.
Btw, happy 4 year anniversary to Makeup Ultrafast! Early user of this shader :D