jawache/principles-green

Spanish intrusions

lynxlynxlynx opened this issue · 2 comments

Not sure if it will be fixed with #17, but currently this page displays some extraneous Spanish copies of principles:
https://principles.green/principles/carbon/ (2 extra)

Considering how it's generated (https://github.com/jawache/principles-green/blob/master/src/_includes/partials/components/principle-list.njk), the files just miss language: es keys in their front matter.

I can submit a PR if that's desired. It might be more error-proof to retire the keys and derive them from the file path, but that's probably more carbon intensive. ;)

This has been fixed in the PR I've opened, this should properly add both the translations and the navigation link to Spanish, you can check the changes in #36

Resurfacing this, as I recently just stumbled upon this error myself