jax-ml/ml_dtypes

pybind11 version update breaks build

wsdmatty opened this issue · 1 comments

pybind11 was updated from 2.10.0 to 2.11.0 and this breaks building of the package.

reading manifest template 'MANIFEST.in'
adding license file 'LICENSE'
adding license file 'LICENSE.eigen'
adding license file 'AUTHORS'
writing manifest file 'ml_dtypes.egg-info/SOURCES.txt'

ERROR Missing dependencies:
        pybind11~=2.10.0
==> ERROR: A failure occurred in build().
 /home/AUR/python-ml-dtypes   master  pacman -Qi pybind11
[sudo] password for matthew:
Name            : pybind11
Version         : 2.11.1-1
Description     : A lightweight header-only library that exposes C++ types in Python and vice versa

I edited the pyproject.toml to reflect the new version and it built properly. However, I do not know if that means it's safe to just bump the version. Here's the changelog for upstream:

v2.11
The minimum version of CMake is now 3.5. A future version will likely move to requiring something like 
CMake 3.15. Note that CMake 3.27 is removing the long-deprecated support for FindPythonInterp if you 
set 3.27 as the minimum or maximum supported version. To prepare for that future, CMake 3.15+ using
 FindPython or setting PYBIND11_FINDPYTHON is highly recommended, otherwise pybind11 will
 automatically switch to using FindPython if FindPythonInterp is not available.

This issue is stale, because we don't depend on pybind11 any more!