Support for SUPEE-6788
sergeifilippov opened this issue · 14 comments
Hi, Looks like this module will break with the pending release of SUPEE-6788 patch.
Can you submit a PR? 👯
Fixed! Just pull latest (1.3.4.1) with modman, composer or git.
Can you update tags for http://packages.firegento.com/#!/enhancedgrid ?
Sure! Will do. I've been having trouble updating Magento Connect (since the
credentials have changed).
Jay
On Nov 16, 2015 10:51 AM, "Dane MacMillan" notifications@github.com wrote:
Can you update tags for http://packages.firegento.com/#!/enhancedgrid ?
—
Reply to this email directly or view it on GitHub
#15 (comment)
.
K this has been updated in all places. Firegento will take a bit of time to update, but it'll be there in both places soon.
Awesome, thanks--will it be 1.3.4.2?
Yep!
On Mon, Nov 16, 2015 at 3:49 PM, Dane MacMillan notifications@github.com
wrote:
Awesome, thanks--will it be 1.3.4.2?
—
Reply to this email directly or view it on GitHub
#15 (comment)
.
@jayelkaake I don't think it was done correctly. Firegento has updated at least a dozen times since Monday.
I just needed to update the module version in github right? I thought it
would pick that up? I also updated the version in Magento Connect. Any idea
why it wouldn't pick it up?
J
On Nov 18, 2015 9:13 AM, "Dane MacMillan" notifications@github.com wrote:
@jayelkaake https://github.com/jayelkaake I don't think it was done
correctly. Firegento has updated at least a dozen times since Monday.—
Reply to this email directly or view it on GitHub
#15 (comment)
.
Hint: Satis recognizes only annotated tags (git tag -a) as versions.
Source: https://github.com/magento-hackathon/composer-repository/blob/master/README.md
In other words, if you did not annotate the tag, you've essentially created what's called a lightweight tag. Annotated tags are needed for releases. See git help tag:
Tag objects (created with -a, -s, or -u) are called "annotated" tags; they contain a creation date, the tagger name and e-mail, a tagging message, and an optional GnuPG signature. Whereas a "lightweight" tag is simply a name for an object (usually a commit object).
Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default.
I used github to create the release that creates tags so I didn't think I and to do that. Composer recognizes this normally. Also I updated the module on Magento Connect and it's not updating on the list... hmm...Magento Connect was updated recently, wonder if that has to do with it...
Anyways, I deleted the tag manually in my console and repushed it using the -a flag. https://github.com/jayelkaake/enhancedgrid/releases Let's see if this works in an hour or so.
Excellent, it shows up now on the non-connect20 section. It oddly removes the previous tag, which I think was v1.3.2.2, so anyone who may have been depending on that will no longer be able to reference it.
Yeah.. . I don't know why the firegento module doesn't just look at the
github tags... And I don't know what to do about the Magento Connect
mobile...
Hmm...
Well at least we got something.
Jay
On Nov 18, 2015 2:42 PM, "Dane MacMillan" notifications@github.com wrote:
Excellent, it shows up now on the non-connect20 section. It oddly removes
the previous tag, which I think was v1.3.2.2, so anyone who may have been
depending on that will no longer be able to reference it.—
Reply to this email directly or view it on GitHub
#15 (comment)
.
This is more than enough--thanks!