jaypipes/ghw

Could not collect windows disk partition infomation

Zzorz opened this issue · 5 comments

Zzorz commented

There is a bug in ghw/pkg/block/block_windows.go
https://github.com/jaypipes/ghw/blob/f38192d6ca0e6d937e83bda5fd17f4870b4db014/pkg/block/block_windows.go#L118
The comparison between * uint32 and * uint32 would be wrong in this circumstance.

Bug can be fixed with method below:

...
if *diskdrive.Index == *diskpartition.DiskIndex {
    ...
}
jaypipes commented

@Zzorz I am so sorry for the delay in getting back to you on this. The notification on this bug report just slipped through my inbox :(

I will look into a fix for this shortly. Thanks very much!

zackbloom commented

Any chance this fix could get merged? Thank you for looking!

zackbloom commented

Thank you so much!