jazz-soft/JZZ

Incorrect Octave being triggered

clemheld opened this issue · 2 comments

Hi Jazz-Soft,

Just want to thank you for this awesome library!

I have picked up an issue that I can recreate over multiple environments + devices.

Using code suggested on the repo I have done a test as follows (I did not include all the code I used to keep it short):

    await port.noteOn(1, 'C2', 127).wait(500).noteOff(1, 'C2',0).close();

What is returned is the incorrect octave for the note that is being triggered.

You will see in the images that I have console.log the note being sent and the note received by MIDI Monitoring software.

Test 1:

MIDI-OX: -1 Octave.
unknown

Test 2: (Different PC)

Midi Viewer: -2 Octave.

image

Thank you for the notice!

The answer is that there is no octave numbering standard and different software can use different convention.
See, for example, this discussion: https://www.midi.org/forum/830-midi-octave-and-note-numbering-standard
JZZ uses "C5" for Middle-C (MIDI 60) to avoid negative octave numbers in the whole MIDI range.

Okay Thank you! It makes sense.