jazzband/django-redis

Is it necessary to get coverage of tests directory?

sauravsharma1998 opened this issue · 2 comments

sauravsharma1998 commented

Hi Everyone,

In the coverage you can observe that the tests directory is also showing the coverage. Is it intentional or something else?

image
WisdomPill commented

makes sense to remove it, would like to make a PR for it?

  • 👍1
sauravsharma1998 commented

Hi @WisdomPill

Any suggestion for - Is it good to combined mypy report with code coverage?
As I have observed in previous commits that there are two possibilities

  1. With mypy report(Where code coverage is ~60%)
  2. Without mypy report(Where code coverage is ~90%)

Tried this one without tests directory for mypy command

Code Coverage is ~90%
https://app.codecov.io/gh/jazzband/django-redis/commit/526df6faf56f9a54f22c55b5f5f6a60276867d78/tree