create a release for django 4.0 compare
tr-conway opened this issue · 23 comments
In auth.py
from django.utils.translation import ugettext_lazy as _ no longer works as ugettext_lazy is removed.
develop branch seems to have solved this issue.
Can a release be created?
Same problem detected still on Django 4.0
If not fixed, I am affraid that django-rest-knox will not be usable at all on Django 4.0 ...
Also The providing_args argument for django.dispatch.Signal is removed. in knox.singals.py
Is django-rest-knox still maintained?
I am also interested in this release.
After upgrading python 3.8.1 to version 3.8.10, my project stopped working.
I am seeing following error
\lib\site-packages\knox\auth.py", line 11, in <module>
from django.utils.translation import ugettext_lazy as _
ImportError: cannot import name 'ugettext_lazy' from 'django.utils.translation'
Pipfile:
django = ">=4.0"
djangorestframework = "~=3.13.1"
django-rest-knox = ">=4.1.0"
django-imagekit = ">=4.1.0"
[requires]
python_version = "3.8.10"
Please suggest me right compatible versions so my project can be fixed.
For now, I have downgraded django 4 to django 3 and it is working
@belugame @James1345
Guys? Maybe somebody can create a release? :)
hey everyone,
I since a long time no longer have an eye on this project, nor James (for even more years). So I don't feel like the right person to make releases. I would recommend for any interested person to make a fork and release from there to a new pip project.
Fully agree with @belugame here, it would even be better if @James1345 could hand-over the pypi name, or someone could claim the pypi name (https://www.python.org/dev/peps/pep-0541/#how-to-request-a-name-transfer).
Dirty fix is to simply pin to the latest commit:
hey everyone,
I since a long time no longer have an eye on this project, nor James (for even more years). So I don't feel like the right person to make releases. I would recommend for any interested person to make a fork and release from there to a new pip project.
I understand, it seems more and more likely that anyone wishing to upgrade to Django 4 will have to rely on a fork. However it would be nice that development would converge on a single fork.
Fully agree with @belugame here, it would even be better if @James1345 could hand-over the pypi name, or someone could claim the pypi name (https://www.python.org/dev/peps/pep-0541/#how-to-request-a-name-transfer).
This would be better indeed.
Otherwise I suggest that some information should be added to the README.md file, stating that the project is not maintained anymore, since what was said, a few months ago in another issue, is no longer true:
It's not actively developed for new features, but if there was a major issue it should get fixed also.
I'll get a release sorted soon
Hadn't realised no-one was watching this any more - sorry for the delay folks!
@James1345 Created a pr #261 to test current python and django version which should help to maintain repo.
Please implement this I want to use knox with 4.0 🙏
I was following a tutorial that had it and can't get passed the part because using version 4.1.0 I get this error:
Traceback (most recent call last): File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\threading.py", line 1009, in _bootstrap_inner self.run() File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\threading.py", line 946, in run self._target(*self._args, **self._kwargs) File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\utils\autoreload.py", line 64, in wrapper fn(*args, **kwargs) File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\core\management\commands\runserver.py", line 115, in inner_run autoreload.raise_last_exception() File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\utils\autoreload.py", line 87, in raise_last_exception raise _exception[1] File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\core\management\__init__.py", line 381, in execute autoreload.check_errors(django.setup)() File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\utils\autoreload.py", line 64, in wrapper fn(*args, **kwargs) File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\__init__.py", line 24, in setup apps.populate(settings.INSTALLED_APPS) File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\apps\registry.py", line 91, in populate app_config = AppConfig.create(entry) File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\apps\config.py", line 211, in create mod = import_module(mod_path) File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\importlib\__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1050, in _gcd_import File "<frozen importlib._bootstrap>", line 1027, in _find_and_load File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 688, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\knox\auth.py", line 11, in <module> from django.utils.translation import ugettext_lazy as _ ImportError: cannot import name 'ugettext_lazy' from 'django.utils.translation' (C:\Users\bestg\AppData\Local\Programs\Python\Python310\lib\site-packages\django\utils\translation\__init__.py)
@NickWinston123 You do not need a release. As I mentioned in #260 (comment) you can use the latest version.
@NickWinston123 You do not need a release. As I mentioned in #260 (comment) you can use the latest version.
I am a noob and didn't know that was a pip command, thanks it is working now!
As said, it is a dirty fix... I hope a release will be uploaded to pypi
I'm going to get a release up on PyPI soon, I promise.
@James1345 any ETA? Thanks!
I created a 4.2.0 release: https://github.com/James1345/django-rest-knox/releases/tag/4.2.0 for Django <=4
Great thank you! Will it be published on pypi.org?
Yes, I just did so :)
https://pypi.org/project/django-rest-knox/4.2.0/