jazzband/django-silk

Cleanup filters form javascript

SebCorbin opened this issue · 2 comments

There is lot of JavaScript on buttons that should not be present (I think it was to replaced them with easier-to-style div), hence submitFilters() and submitEmptyFilters() are not needed.

@SebCorbin hi there. I would like to pick up this issue. Any more clarity on the exact nature of this issue?

If you look at the HTML/CSS/JS of the django-silk views, a lot can be streamlined to basic HTML/CSS instead of the overly complex (and exploded) current JS code.

If you take the submitFilters() and submitEmptyFilters() for example, I think these could be entirely replaced by <button type="submit"> and <button type="reset"> elements