jbaiter/pdiiif

Failed to generate PDF: r.findLastIndex is not a function

andybuki opened this issue · 11 comments

andybuki commented

Hi Johanes,

i tried to generate a manifest in Firefox and got following issue:

"Failed to generate PDF: r.findLastIndex is not a function"

image

In Chrome it works correctly.

andybuki commented

Safari -> same issue

jbaiter commented

Does this happen for every manifest you've tried or is this specific to just some manifests?

andybuki commented

I just tried it on mac os safari/firefox -> everything works right.
I get this issue on Windows Firefox version 102.12.0 64 Bit.
Safari issue was one from users (I don't know the details)

  • 👍1
andybuki commented

May be it can help i add image with an issue:

image

I just noticed that it adds semicolon to the link:

Error fetching https://iiif-content.crossasia.org/xasia/dllm+dllm_00011171+457165/full/full/0/default.jpg:
It works only without ":"

  • 👍1
  • ❤️1
jbaiter commented

I'm pretty much at a loss at what could cause this. Uint8Array.findLastIndex has been part of Firefox since version 47, which was released in 2016. Can you try a few times and see if that changes things? Also, are you absolutely sure that this error occurs on Firefox 102?

andybuki commented

About Safari's version by some user i'll try to know tomorrow.
I'll try on other windows computer today and let you know too.
Here is a screenshot of my working mashine. All updates and most changes can do only admin.
image

  • 👍1
jbaiter commented

Thank you! I'll try to set up a windows VM and see if I can reproduce it 👍

jbaiter commented

OK, I probably shouldn't analyze bugs immediately after a long day of work :-)
Turns out I had confused TypedArray#findLastIndex (which takes a predicate) with TypedArray#lastIndexOf (which takes a value). The former has only been part of Firefox since version 104 and Safari 15.4 (from last year), so it's obviously not in Firefox 102 or older Safari versions.
So sorry about that, I'll implement a polyfill for older versions, thank you for reporting the issue!

andybuki commented

I agree with you, it is an old versions. in other computer everything works right. Thanks for support.

jbaiter commented

Nono,I was mistaken in my earlier comments (due to me confusing it with a different function), browsers without TypedArray#findLastIndex are definitely not old, the API is just very new and I wasn't aware of that when writing the code. The next release will include the polyfill and it should work on more browsers :-)