jbe2277/waf

this missing for extension method?

marcantoinecouture opened this issue · 4 comments

I think there's a "this" missing in the method signature. Is it an error?
Thank you

public static T GetNextElementOrDefault<T>(IEnumerable<T> collection, T current)

No, the this is not missing here. I use the extension method syntax only for the most important helper methods. Keep the IntelliSense list clean 😃. The GetNextElementOrDefault method is not that important.

Thank you for the feedback.

I understand, but I find it strange to call all other extension methods using the regular syntax and this one with the static class.
A GetPreviousElementOrDefault extension method could be also useful.

Thank you for the answer

Hi,
I would like to help you with those changes. I really appreciate this framework. Do you still refuse contributions?

Yes, I still refuse contributions.

Resolving this issue is not much effort - but I'm still not 100% convinced that this change should be done. I will review this issue when I'm going to create the next WAF release.