Refactoring: Replace ClapMediaOrientation with ClapImageRatio
Closed this issue · 1 comments
jbilcke-hf commented
Context
Our current ClapMediaOrientation is a bit limited, to portrait, landscape and square
It initially made sense when we only had either landscape or portrait, but today with square it becomes confusing,
especially since a more common word for this kind of stuff is "image ratio".
Solution
- Rename
ClapMediaOrientation
toClapImageRatio
- replace il all the code base
- add a migration code for older projects
jbilcke-hf commented
done