jbrukh/bayesian

Panic if underflow is detected in `SafeProbScores`

yml opened this issue · 3 comments

yml commented

SafeProbScores ... If an underflow is detected, this method panics

Source

I am getting a bit confused by the comment in the method above according to the doc this method is suppose to panic but the code instead returns an error.

Am I missing something ?

Your confusion is not unwarranted -- the comment is incorrect. In the case of underflow, the method will return an error. The comment still applies if you replace "returns an error" for "panics".

Will fix.

yml commented

Waouuu that was fast :-) Thank you very much for releasing this code and accepting PR.

My pleasure. Thanks for contributing.