Editing a duel creates new matches
Closed this issue · 3 comments
The title says it all. ;)
But if we edit a duel to change its players, what happens to the matches of the previous players? And what if they have been played?
Maybe it shouldn't be possible to edit the players of a duel if any of its matches has already been played.
I don't like this. The automagic match creation should be a facility available only when creating a duel.
When editing you should only be able to add or remove them by hand.
Oh, and btw: are the players still specified in the matches instead of in the duel data model? They should be stored in the duel. Is there any case where it would make sense to add a match with different players inside a duel between two players?
I guess not. And yes, we should move them to the Duel model, as there will
be no standalone matches. I'll create a new issue.
On 9 April 2012 22:02, Pedro Coelho <
reply@reply.github.com
wrote:
I don't like this. The automagic match creation should be a facility
available only when creating a duel.When editing you should only be able to add or remove them by hand.
Oh, and btw: are the players still specified in the matches instead of in
the duel data model? They should be stored in the duel. Is there any case
where it would make sense to add a match with different players inside a
duel between two players?
Reply to this email directly or view it on GitHub:
#29 (comment)
This should be solved by now.