jchristn/WatsonWebsocket

SetInvalidCertificateAcceptance not entering in if netframework.

Closed this issue · 3 comments

While looking for a workaround to #101, I noticed that in SetInvalidCertificateAcceptance

private void SetInvalidCertificateAcceptance()

when running in Net 6.0, the execution entered the if at line 575 (#if NET || NETSTANDARD || NETCOREAPP), but when running in Net Framework 4.8, it did not enter into the if at line 571 (#if NETFRAMEWORK).

Hi! Sorry for the delay, I added Console.WriteLine("Hello!"); to both client and server and tested on .NET 4.6.1. It appears to enter for me. I'll test on .NET Framework 4.8 next.

image

Hi, I just added targeting for net48 and tested, and it entered correctly. I'll publish a patch with the proper targeting momentarily.
image

Please reopen if the issue continues after upgrading to 4.0.4!

NuGet: https://www.nuget.org/packages/WatsonWebsocket/4.0.4
Commit: ae48a84